Skip to content

Escaped part separator in composite node ID string and GUID values #8300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented May 21, 2025

Summary of the changes (Less than 80 chars)

  • Escaped part separator in composite node ID string and GUID values.

Closes #8193

@glen-84 glen-84 added the 🍒 cherry-pick Consider cherry-picking these changes into the previous major version. label May 21, 2025
@michaelstaib michaelstaib added this to the HC-15.1.6 milestone May 21, 2025
@michaelstaib michaelstaib merged commit c6c658d into main May 23, 2025
104 checks passed
@michaelstaib michaelstaib deleted the gai/issue-8193 branch May 23, 2025 12:27
Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (6a3b7a3) to head (4773942).
Report is 76 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #8300       +/-   ##
==========================================
- Coverage   74.16%       0   -74.17%     
==========================================
  Files        2677       0     -2677     
  Lines      140790       0   -140790     
  Branches    16371       0    -16371     
==========================================
- Hits       104421       0   -104421     
+ Misses      30774       0    -30774     
+ Partials     5595       0     -5595     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 cherry-pick Consider cherry-picking these changes into the previous major version. 🌶️ hot chocolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CompositeNodeIdValueSerializer with 2 Guids might generate invalid Id's
2 participants