Skip to content

Updated validation to disallow skip/include on root subscription fields #8276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2025

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented May 8, 2025

Summary of the changes (Less than 80 chars)

  • Updated validation to disallow skip/include on root subscription fields.

Closes #4382

@glen-84 glen-84 added the 💥 breaking-changes This PR contains breaking changes. label May 8, 2025
@glen-84 glen-84 added this to the HC-16.0.0 milestone May 8, 2025
glen-84 added a commit that referenced this pull request May 8, 2025
glen-84 added a commit that referenced this pull request May 9, 2025
@michaelstaib michaelstaib merged commit 238673a into main May 28, 2025
104 of 106 checks passed
@michaelstaib michaelstaib deleted the gai/issue-4382 branch May 28, 2025 10:45
michaelstaib pushed a commit that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 breaking-changes This PR contains breaking changes. 🌶️ hot chocolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track: [RFC] Prevent @skip and @include on root subscription selection set
2 participants