chore(lib/trie): LoadFromMap as function for transactional trie mutation
#2875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
requested review from
noot,
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj and
kishansagathiya
as code owners
qdm12
changed the title
LoadFromMap as functionLoadFromMap as function for transactional trie mutation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #2875 +/- ##
===============================================
+ Coverage 63.05% 63.30% +0.24%
===============================================
Files 218 219 +1
Lines 27209 27357 +148
===============================================
+ Hits 17157 17317 +160
+ Misses 8469 8447 -22
- Partials 1583 1593 +10 |
EclesioMeloJunior
approved these changes
Oct 10, 2022
- Trie mutation should be transactional/atomic as a method - Changed from method to function to avoid leaving a trie in a bad state - Function returns a new empty trie with all the key and value pairs given
qdm12
force-pushed
the
qdm12/trie/loadfrommap
branch
from
e7c6116 to
46df10f
Compare
EclesioMeloJunior
pushed a commit
that referenced
this pull request
Oct 12, 2022
…ation (#2875) - Trie mutation should be transactional/atomic as a method, in case an error occurs - Changed from method to function to avoid leaving a trie in a bad state - Function returns a new empty trie with all the key and value pairs given
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This will become important for lazy loading where a disk write operation could fail for real.
Tests
go test -tags integration github.com/ChainSafe/gossamer/lib/trie/...Issues
Related to #2838
Primary Reviewer
@jimjbrettj