Issue #295: Implement support for the OpenSSH-specific ChaChaPoly SSH… #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Castaglia
force-pushed
the
proxy-chachapoly-issue295
branch
from
dd81ebe to
8e3f533
Compare
Castaglia
commented
May 14, 2025
lib/proxy/ssh/auth.c
Outdated
| @@ -1178,6 +1178,8 @@ int proxy_ssh_auth_handle(struct proxy_ssh_packet *pkt, | |||
| if (msg_type == PROXY_SSH_MSG_USER_AUTH_REQUEST) { | |||
| uint32_t len; | |||
|
|
|||
| (void) len; | |||
|
|
|||
There was a problem hiding this comment.
This is to quell the following compiler warning:
lib/proxy/ssh/auth.c:1179:14: warning: variable 'len' set but not used [-Wunused-but-set-variable]
1179 | uint32_t len;
Castaglia
commented
May 14, 2025
| @@ -3041,6 +3041,8 @@ static int decrypt_openssh_data(pool *p, const char *path, | |||
| uint32_t buflen, key_len, rounds, salt_len, len = 0; | |||
| size_t passphrase_len; | |||
|
|
|||
| (void) len; | |||
|
|
|||
There was a problem hiding this comment.
These changes, not related to the ChaChaPoly implementation, are to quell compiler warnings about "set but not used" values.
Castaglia
force-pushed
the
proxy-chachapoly-issue295
branch
from
8e3f533 to
d6d4145
Compare
Castaglia
force-pushed
the
proxy-chachapoly-issue295
branch
from
d6d4145 to
de6bb2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… algorithm.