Skip to content
This repository was archived by the owner on Aug 14, 2019. It is now read-only.

Support for Multiple Filter(startAt, endAt, limitToFirst, limitToEnd) #6

Merged
merged 2 commits into from
Jul 12, 2018

Conversation

yottahmd
Copy link
Contributor

@yottahmd yottahmd commented Jul 12, 2018

Hello,

I'm creating an application using this awesome library and I realized that it doesn't support using filter "startAt" with "limitToFirst" together in a query.

According to the firebase document, "startAt" and "limitToFirst" should be able to be used together.
https://firebase.google.com/docs/database/admin/retrieve-data?hl=en&authuser=1#header_4

So, I fixed a little of the codes to support that case.

Please check it and merge.

Thanks in advance😀

@wwwy3y3 wwwy3y3 self-requested a review July 12, 2018 09:58
@wwwy3y3 wwwy3y3 added the bug Something isn't working label Jul 12, 2018
Copy link
Contributor

@wwwy3y3 wwwy3y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @hayo0914
Didn't notice this bug 😂

@wwwy3y3 wwwy3y3 merged commit 39c8017 into CannerCMS:master Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants