Skip to content

ci(image): adjust build flow #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Conversation

grieve54706
Copy link
Contributor

@grieve54706 grieve54706 commented Nov 7, 2024

We found the amd64 image(first done) will be covered by the arm64 image(later).
We want to keep them by different runners for different arch os runners in the future.

Adjust by following this page from Docker official
https://docs.docker.com/build/ci/github-actions/multi-platform

We start to use the GitHub beta arm runner.
https://github.blog/changelog/2024-06-24-github-actions-ubuntu-24-04-image-now-available-for-arm64-runners/

And I also merge build-dev-image.yml into build-image.yml. They are so similar.

@grieve54706 grieve54706 force-pushed the chore/ci-docker-image-lose-amd64 branch 3 times, most recently from aedb85a to e0ba61a Compare November 8, 2024 06:54
@github-actions github-actions bot added ibis python Pull requests that update Python code labels Nov 8, 2024
@grieve54706 grieve54706 force-pushed the chore/ci-docker-image-lose-amd64 branch 3 times, most recently from fcfbcd0 to 7a5a3ca Compare November 8, 2024 07:29
@grieve54706 grieve54706 force-pushed the chore/ci-docker-image-lose-amd64 branch from 7a5a3ca to cfa0eb7 Compare November 8, 2024 07:36
@grieve54706 grieve54706 force-pushed the chore/ci-docker-image-lose-amd64 branch from cfa0eb7 to 2d49c9f Compare November 8, 2024 08:26
@grieve54706 grieve54706 changed the title ci(image): adjust for lost amd64 ci(image): adjust build flow Nov 8, 2024
@grieve54706 grieve54706 requested a review from goldmedal November 8, 2024 08:35
@grieve54706 grieve54706 marked this pull request as ready for review November 8, 2024 08:35
Copy link
Contributor

@goldmedal goldmedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grieve54706 it's really nice. 👍

@goldmedal goldmedal merged commit ceec377 into main Nov 11, 2024
14 checks passed
@goldmedal goldmedal deleted the chore/ci-docker-image-lose-amd64 branch November 11, 2024 02:43
@grieve54706 grieve54706 added this to the 0.11.3 milestone Nov 12, 2024
grieve54706 added a commit that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ibis python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants