Skip to content

test(bigquery): use fixed date instead of current date #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2024
Merged

test(bigquery): use fixed date instead of current date #846

merged 1 commit into from
Oct 24, 2024

Conversation

grieve54706
Copy link
Contributor

Due to the current date changing daily, the test can not exactly assert what is expected.

@grieve54706 grieve54706 requested a review from goldmedal October 24, 2024 04:36
@github-actions github-actions bot added ibis python Pull requests that update Python code labels Oct 24, 2024
@goldmedal goldmedal merged commit 10ee35c into main Oct 24, 2024
8 checks passed
@goldmedal goldmedal deleted the bugfix/test-avoid-current branch October 24, 2024 06:51
grieve54706 added a commit that referenced this pull request Dec 13, 2024
@grieve54706 @goldmedal
test(bigquery): use fixed date instead of current date (#846)
dbc87b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldmedal goldmedal goldmedal approved these changes

Assignees
No one assigned
Labels
bigquery ibis python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grieve54706 @goldmedal