feat(metadata): provide db version #845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grieve54706
force-pushed
the
feature/provide-db-version
branch
2 times, most recently
from
7fe6635 to
fd5deda
Compare
grieve54706
force-pushed
the
feature/provide-db-version
branch
from
fd5deda to
21030aa
Compare
goldmedal
reviewed
Oct 24, 2024
| json={"connectionInfo": connection_info}, | ||
| ) | ||
| assert response.status_code == 200 | ||
| assert response.text is not None |
There was a problem hiding this comment.
Is it possible to assert the version text? or is it not a static value?
There was a problem hiding this comment.
We use the head tag. It is not a static version.
| json={"connectionInfo": connection_info}, | ||
| ) | ||
| assert response.status_code == 200 | ||
| assert response.text is not None |
There was a problem hiding this comment.
Same as the issue for clickhouse.
There was a problem hiding this comment.
We use the latest tag. It is not a static version.
goldmedal
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new API
/v2/connector/{data_source}/metadata/versionto provide the DB version.The request body follows other metadata APIs.