fix(bigquery): fix Interval precision is None and format interval to str #843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bigquery
ibis
python
|
Follow issue ibis-project/ibis#10357 |
goldmedal
reviewed
Oct 23, 2024
|
|
||
|
|
||
| class BigQueryType(datatypes.BigQueryType): | ||
| default_interval_precision = "s" |
There was a problem hiding this comment.
What is the purpose of this option? We set s here but the result still prints the microsecond 🤔 .
There was a problem hiding this comment.
Yes, it's different things. The field is for ibis transfer str to type. The printed result is from the pandas dataframe.
goldmedal
approved these changes
Oct 23, 2024
grieve54706
added a commit
that referenced
this pull request
Dec 13, 2024
…str (#843) * fix(bigquery): fix Interval precision is None and format interval to str * chore: re-trigger ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found an error
ibis.common.exceptions.IbisTypeError: Interval precision is None.Because the BigQuery client returns the interval type in the schema, it is not with precision.
We found the BigQueryType of the ibis has a field
default_interval_precision. We can override the class until the ibis fixes it.We also handle the date offset type of pandas that is not serializable.