Skip to content

fix(core): fix the field resolving for the relationship column #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

goldmedal
Copy link
Contributor

@goldmedal goldmedal commented Oct 11, 2024

Description

The relationship column should be ignored when resolving the corresponding field. Otherwise, the resolved columns will always contain the relationship column.

Use RelationType.resolveAnyField to follow the same behavior.

@goldmedal goldmedal marked this pull request as ready for review October 11, 2024 05:28
@goldmedal goldmedal requested a review from grieve54706 October 11, 2024 05:28
Copy link
Contributor

@grieve54706 grieve54706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grieve54706 grieve54706 merged commit 2721d8b into main Oct 11, 2024
12 of 13 checks passed
@grieve54706 grieve54706 deleted the feature/fix-scope-resolve-relationship branch October 11, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants