feat(ibis): introduce the relationship validation #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grieve54706
reviewed
Oct 8, 2024
| }, | ||
| ) | ||
| assert response.status_code == 422 | ||
| assert response.text is not None |
There was a problem hiding this comment.
Could you provide the error message?
There was a problem hiding this comment.
well, it should be 204 withou text actually. I provided the wrong input SQL. I'll fix it. Thanks
| @@ -197,7 +211,7 @@ def test_validate_with_unknown_rule(): | |||
| assert response.status_code == 422 | |||
| assert ( | |||
| response.text | |||
| == "The rule `unknown_rule` is not in the rules, rules: ['column_is_valid']" | |||
| == "The rule `unknown_rule` is not in the rules, rules: ['column_is_valid', 'relationship_is_valid']" | |||
There was a problem hiding this comment.
How about importing the rules
from app.model.validator import rules
response.text == f"The rule `unknown_rule` is not in the rules, rules: {rules}"| ) | ||
|
|
||
| assert response.status_code == 422 | ||
| assert response.content == b"Relationship not_found not found in manifest" |
There was a problem hiding this comment.
You can use response.text.
grieve54706
approved these changes
Oct 8, 2024
grieve54706
pushed a commit
that referenced
this pull request
Dec 13, 2024
* implement relationship validation * fix tests for other source * fix the method argument * fix test * fix test * address comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a new validation rule to validate if a relationship is valid. This validation is used to ensure the real data layout matches the definition. We have some rules for different relationship types.
API Request format
Rule name
relationship_is_validRequest body
Response
The validation result will be shown in the error message:
is_related: If the count of the join result is greater than 0.left_table_unique: If the join column of the left table is unique.right_table_unique: If the join column of the right table is unique.