feat(core): enhance scope analysis and implement ByPass Function #802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grieve54706
approved these changes
Sep 25, 2024
Comment on lines
-30
to
+31
| {"name": "orderkey", "expression": "o_orderkey", "type": "integer"}, | ||
| {"name": "custkey", "expression": "o_custkey", "type": "integer"}, | ||
| {"name": "o_orderkey", "type": "integer"}, | ||
| {"name": "o_custkey", "type": "integer"}, |
There was a problem hiding this comment.
We can't purely rename the column name after this PR.
There was a problem hiding this comment.
Yes. In this case, we won't provide any remote schema for them. Wren core will use the column without expression as the remote column.
grieve54706
pushed a commit
that referenced
this pull request
Dec 13, 2024
* remove unused return result * implement ByPass function for udf, udaf and udwf * format and enhance the doc * create table schema refer to the column type * fix the scope analyze for the CTE and subquery * fix the interval unparsing and enable the tests * enable the model test * fix compile fails * fix the python test * fix ibis test * fix ibis test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description