Skip to content

fix(core): fix the behaviors of dynamic query #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

goldmedal
Copy link
Contributor

Description

  • Fix count(*) query with the filter that invokes any calculated field.
  • Fix count(*) for a query with the relation table or join.
  • Fix selecting wildcard from a model should exclude the calculated fields.

@goldmedal goldmedal changed the title Fix the behaviors of dynamic query fix(core): fix the behaviors of dynamic query Sep 2, 2024
@goldmedal goldmedal marked this pull request as ready for review September 2, 2024 09:37
Copy link
Contributor

@grieve54706 grieve54706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grieve54706 grieve54706 merged commit ca17f78 into main Sep 4, 2024
8 of 9 checks passed
@grieve54706 grieve54706 deleted the bugfix/fix-dynmaic-query branch September 4, 2024 03:53
grieve54706 pushed a commit that referenced this pull request Dec 13, 2024
* fix count(*) with calculated field filter

* fix count(*) from the model or join

* fix selecting wildcard exclude calculated field

* fix the style

* fix ibis clickhouse test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants