Skip to content

feat(ibis): adjust json data type and format #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Conversation

grieve54706
Copy link
Contributor

We abandoned the unused feature column_dtypes.
If the dtype is datetime, we will format the data to string when building JSON.

@grieve54706
Copy link
Contributor Author

The CI failed cause is from Trino container GENERIC_INTERNAL_ERROR, message="nodes is empty". We can ignore this issue.

Copy link
Contributor

@goldmedal goldmedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grieve54706 Overall LGTM.

@goldmedal goldmedal merged commit 985fcb9 into main Aug 30, 2024
5 of 6 checks passed
@goldmedal goldmedal deleted the feature/format-datetime branch August 30, 2024 09:38
grieve54706 added a commit that referenced this pull request Dec 13, 2024
* feat(ibis): remove column_dtypes

* feat(ibis): adjust json data type and format

* test(v3): edit test case to follow up
grieve54706 added a commit that referenced this pull request Dec 13, 2024
* feat(ibis): remove column_dtypes

* feat(ibis): adjust json data type and format

* test(v3): edit test case to follow up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants