Fix the scope analysis of the CTEs #729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmedal
commented
Aug 5, 2024
Comment on lines
+723
to
+725
| WITH t1 as (SELECT customer.custkey FROM customer), | ||
| t2 as (SELECT (t1.custkey + 1) as custkey_plus FROM t1) | ||
| SELECT custkey_plus FROM t2 |
There was a problem hiding this comment.
We only analyze the top-level expression. We won't dig into the child of this expression. So, the number of expression sources of custkey_plus is zero.
|
@goldmedal thanks for your help! the issue seems fixed after some manual testing |
grieve54706
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe
We didn't build the correct scope for the CTE. This leads to some analysis errors when making the decision point analysis.