Skip to content

feat: trino integration get tables name api developed #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

himanshu634
Copy link
Contributor

@himanshu634 himanshu634 commented Jul 29, 2024

Created:
(POST) /trino/metadata/tables API

Note:
(POST) /trino/metadata/constraints API
this API has not been developed because trino doesn't maintain primary key info.
Here is a reference : StackOverflow-reference

@grieve54706
Copy link
Contributor

grieve54706 commented Jul 29, 2024

Please follow the development.md#getting-started to install pre-commit and follow the Ruff lint.
And add a test case to ensure the feature works.

fredalai

This comment was marked as outdated.

@himanshu634
Copy link
Contributor Author

I have followed @grieve54706 's comment @fredalai Could you please trigger again?

@grieve54706
Copy link
Contributor

I have followed @grieve54706 's comment @fredalai Could you please trigger again?

Sure, my pleasure.

@grieve54706 grieve54706 self-requested a review July 29, 2024 07:32
@grieve54706 grieve54706 requested a review from wwwy3y3 July 29, 2024 09:20
@himanshu634 himanshu634 force-pushed the feature/trino-integration branch from 019548a to 2a6d9f0 Compare July 29, 2024 10:44
Copy link
Contributor Author

@himanshu634 himanshu634 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks done from my side

Copy link
Contributor

@grieve54706 grieve54706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grieve54706 grieve54706 requested review from onlyjackfrost and removed request for wwwy3y3 and onlyjackfrost July 30, 2024 05:27
@grieve54706
Copy link
Contributor

@onlyjackfrost, would you take a look?

@grieve54706 grieve54706 merged commit 1cb6067 into Canner:main Aug 2, 2024
1 check passed
grieve54706 pushed a commit that referenced this pull request Dec 13, 2024
* feat: trino integration added

* fix: all test cases is being passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants