Enhance the analysis API for the location of Join Criteria and source columns #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grieve54706
approved these changes
Jul 25, 2024
grieve54706
pushed a commit
that referenced
this pull request
Dec 13, 2024
… columns (#714) * add node location for join criteria * add source column for all expr sources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #683
close #690
JoinCriteria Location
The location of the join criteria is the most left-side expression. Because of the limitation of trino parser, we can't dedicate the precision location of the join type syntax (
ONorUSING). For example:The location of the criteria is the location of
a.a1.