Fix RemoveWrenPrefixRule for being executed by DataFusion
#687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmedal
commented
Jul 23, 2024
Comment on lines
+22
to
+24
| /// Apply Wren Rules to the context for sql generation. | ||
| /// TODO: There're some issue for unparsing the datafusion optimized plans. | ||
| /// Disable all the optimize rule for sql generation temporarily. |
There was a problem hiding this comment.
There's an issue about unparsing the optimized plans to the SQL string. I'll file the issue in Datafusion.
grieve54706
approved these changes
Jul 24, 2024
grieve54706
pushed a commit
that referenced
this pull request
Dec 13, 2024
* fix the remove fix rule * provide api for apply wren rules * change the tests to run datafusion directly * throw error if failed * disable some broken tests * register table for wren datasets * cargo fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RemoveWrenPrefixRulefor the correct plan schema.Fix the sqllogictests
I didn't find the sqllogictests is broken. So, many test cases are failed and skipped but I didn't know. I commented out some cases and I'll file the issues for them.