Add documents #677
Merged
Add documents #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grieve54706
force-pushed
the
chore/contributing
branch
from
7d69356 to
639019a
Compare
grieve54706
force-pushed
the
chore/contributing
branch
from
b0e3654 to
cd4d7d1
Compare
goldmedal
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Thanks @grieve54706 for the awesome work. Just one comment. Others LGTM.
ibis-server/README.md
Outdated
| ## Application structure | ||
| The application consists of three main parts: | ||
| 1. [ibis-server](./): a Python web server powered by FastAPI and Ibis | ||
| 2. [wren-modeling-rs](../wren-modeling-rs): a modeling core written in Rust powered by [Apache/DataFusion](https://github.com/apache/datafusion) |
There was a problem hiding this comment.
Suggested change
| 2. [wren-modeling-rs](../wren-modeling-rs): a modeling core written in Rust powered by [Apache/DataFusion](https://github.com/apache/datafusion) | |
| 2. [wren-modeling-rs](../wren-modeling-rs): a modeling core written in Rust powered by [Apache DataFusion](https://github.com/apache/datafusion) |
grieve54706
added a commit
that referenced
this pull request
Dec 13, 2024
* Add CONTRIBUTING.md, DEVELOPMENT.md and CODE_OF_CONDUCT.md * Add SUPPORT.md * Adjust folder struct * Add how-to-add-data-source.md * Add description about strict markers * Edit datafusion name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documents