Mask sensitive information #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmedal
reviewed
Jul 16, 2024
ibis-server/app/model/__init__.py
Outdated
Comment on lines
65
to
69
| host: str | ||
| port: int | ||
| database: str | ||
| user: str | ||
| password: str | ||
| password: SecretStr |
There was a problem hiding this comment.
I think we should mask all info in the connection info. People might not want to expose their host, port, or any information that could make others try to access their machine.
grieve54706
force-pushed
the
feature/sensitive-mark
branch
from
00f67b2 to
30f78f6
Compare
goldmedal
approved these changes
Jul 16, 2024
grieve54706
added a commit
that referenced
this pull request
Dec 13, 2024
* Mask sensitive * Make all fields of connection info be secret
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mask all fields of connection info.