-
Notifications
You must be signed in to change notification settings - Fork 82
Provide the batch SQL analysis API #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4a98076
to
2f4195c
Compare
assert len(result) == 4 | ||
assert len(result[0]) == 1 | ||
assert len(result[1]) == 1 | ||
assert len(result[2]) == 2 | ||
assert len(result[3]) == 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add more expected results to let other contributors know the result content format?
@goldmedal Could you add more information about the response content in the pull request? To explain why it needs two axes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @goldmedal.
Thanks @grieve54706 |
* remove unused api * add Deprecated annotation for v1 api * add analysis batch api * add required ibis api * enhance python test * fix test
Description
Implement the batch SQL analysis API
URL
Request Body
manifestStr
: based64 manifset json string.sqls
: the list of input sql.The
manifestStr
is encoded from:Response
The result format is
List<List<QueryAnalysis>>
. You can check #548 for the detail ofQueryAnalysis