Skip to content

Rename API and deconstruct test class #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Conversation

grieve54706
Copy link
Contributor

  • Change API path from /v2/ibis/{data_source} to /v2/connector/{data_source}
  • Deconstruct test class

@grieve54706 grieve54706 force-pushed the feature/rename-api branch 4 times, most recently from 377fd14 to 6a0ef71 Compare July 5, 2024 06:15
Copy link
Contributor

@goldmedal goldmedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grieve54706, overall LGTM but one comment.

from app.main import app
from tests.confest import file_path

# pytestmark = pytest.mark.postgres
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct? I guess it should not be commented?

Suggested change
# pytestmark = pytest.mark.postgres
pytestmark = pytest.mark.postgres

@grieve54706 grieve54706 force-pushed the feature/rename-api branch from 6a0ef71 to e55e31f Compare July 5, 2024 07:16
@grieve54706 grieve54706 force-pushed the feature/rename-api branch from e55e31f to 85a490f Compare July 5, 2024 07:25
@grieve54706 grieve54706 merged commit 975bcec into main Jul 5, 2024
4 checks passed
@grieve54706 grieve54706 deleted the feature/rename-api branch July 5, 2024 07:36
grieve54706 added a commit that referenced this pull request Dec 13, 2024
* Change API base name to connector

* Deconstruct test class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants