Remove redundent brackets for the join syntax #649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grieve54706
approved these changes
Jul 4, 2024
| @@ -122,7 +179,7 @@ def test_query(self, clickhouse: ClickHouseContainer): | |||
| ) | |||
| assert response.status_code == 200 | |||
| result = response.json() | |||
| assert len(result["columns"]) == len(self.manifest["models"][0]["columns"]) | |||
| assert len(result["columns"]) == 9 | |||
There was a problem hiding this comment.
Why use a constant instead of an object reference?
There was a problem hiding this comment.
Because the model has calculated fields now, the number of columns will be different. In dynamic query mode, the calculated fields won't be selected when select all.
Comment on lines
299
to
303
| params={"limit": 1}, | ||
| json={ | ||
| "connectionInfo": connection_info, | ||
| "manifestStr": self.manifest_str, | ||
| "sql": 'SELECT name as customer_name FROM "Orders" join "Customer" on "Orders".custkey = "Customer".custkey WHERE custkey = 370 LIMIT 1', |
There was a problem hiding this comment.
Two limit could keep only one.
grieve54706
pushed a commit
that referenced
this pull request
Dec 13, 2024
* remove redundant brackets * add relationship test for clickhouse * enable dynamic-query by default * fix checkstyle * fix dry plan test * remove redundant limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #647
The join relation with brackets is valid for Trino but isn't for Clickhouse.
Because
ibiscan't handle the syntax for Clickhouse, we have stopped generating the join syntax with brackets in this PR.Related Changed
dynamic-querywill be enable by default for wren-engine.