Add data source ClickHouse #646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmedal
reviewed
Jul 3, 2024
Comment on lines
+50
to
+57
| json_obj = orjson.loads( | ||
| orjson.dumps( | ||
| data, | ||
| option=orjson.OPT_SERIALIZE_NUMPY | ||
| | orjson.OPT_PASSTHROUGH_DATETIME | ||
| | orjson.OPT_SERIALIZE_UUID, | ||
| default=default, | ||
| ) |
| assert response.status_code == 422 | ||
| assert response.text is not None | ||
|
|
||
| def test_validate_with_unknown_rule(self, clickhouse: ClickHouseContainer): |
There was a problem hiding this comment.
I found the test cases for each data source are duplicate. Maybe we can have an abstract testing function for different data source. WDYT?
There was a problem hiding this comment.
They have different parameters about databases. They can not be one abstract function.
goldmedal
approved these changes
Jul 3, 2024
goldmedal
reviewed
Jul 3, 2024
| return ch | ||
|
|
||
|
|
||
| @pytest.mark.postgres |
There was a problem hiding this comment.
Is it correct? I guess it should be clickhouse?
Suggested change
| @pytest.mark.postgres | |
| @pytest.mark.clickhouse |
|
Thanks @grieve54706 |
grieve54706
added a commit
that referenced
this pull request
Dec 13, 2024
* Add data source ClickHouse * Make mysql support connection url * Fix marker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make
POST /v2/ibis/{data_source}/querysupport new data sourceClickHouseRequest body
requiredrequiredrequiredrequiredrequired{ "sql": "select * from \"Orders\" limit 1", "manifestStr": "eyJjYXRhbG9nIjoibXlfY2F0YWxvZyIsInNjaGVtYSI6Im15X3...", "connectionInfo": { "host": "localhost", "port": 1433, "database": "dbname", "user": "username", "password": "password" } }or
required{ "sql": "select * from \"Orders\" limit 1", "manifestStr": "eyJjYXRhbG9nIjoibXlfY2F0YWxvZyIsInNjaGVtYSI6Im15X3...", "connectionInfo": { "connectionUrl": "clickhouse://username:password@localhost:1433/dbname" } }Response body
{ "columns": [ "o_orderkey", "o_custkey", "o_orderstatus", "o_totalprice", "o_orderdate", "o_orderpriority", "o_clerk", "o_shippriority", "o_comment" ], "data": [ [ 1, 370, "O", 172799.49, 820540800000, "5-LOW", "Clerk#000000951", 0, "nstructions sleep furiously among " ] ], "dtypes": { "o_orderkey": "int32", "o_custkey": "int32", "o_orderstatus": "object", "o_totalprice": "object", "o_orderdate": "object", "o_orderpriority": "object", "o_clerk": "object", "o_shippriority": "int32", "o_comment": "object" } }Additional information
We use orjson instead of
ujsonin the Pandas to take more control.Resolve #638 too