Add query parameter limit #644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmedal
reviewed
Jul 1, 2024
ibis-server/app/routers/v2/ibis.py
Outdated
| @@ -27,12 +27,15 @@ def query( | |||
| data_source: DataSource, | |||
| dto: QueryDTO, | |||
| dry_run: Annotated[bool, Query(alias="dryRun")] = False, | |||
| limit: int = 100, | |||
There was a problem hiding this comment.
I think the default value could be unlimit. It can also be used by the user who want to get all result.
goldmedal
approved these changes
Jul 2, 2024
grieve54706
added a commit
that referenced
this pull request
Dec 13, 2024
* Add query parameter limit * Make limit not with default * Add test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new query parameter
limitfor query API to limit data size.POST /v2/ibis/{data_source}/query?
limit=1