Implement Snowflake data source #524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grieve54706
force-pushed
the
feature/snowflake-data-source
branch
5 times, most recently
from
6583ef4 to
316540c
Compare
goldmedal
reviewed
Apr 18, 2024
wren-main/src/main/java/io/wren/main/connector/snowflake/SnowflakeClient.java
Outdated
Show resolved
Hide resolved
wren-main/src/main/java/io/wren/main/connector/snowflake/SnowflakeMetadata.java
Outdated
Show resolved
Hide resolved
wren-main/src/main/java/io/wren/main/connector/snowflake/SnowflakeRecordIterator.java
Outdated
Show resolved
Hide resolved
wren-main/src/main/java/io/wren/main/connector/snowflake/SnowflakeSqlConverter.java
Outdated
Show resolved
Hide resolved
wren-tests/src/test/java/io/wren/testing/TestConfigResource.java
Outdated
Show resolved
Hide resolved
wren-tests/src/test/java/io/wren/testing/snowflake/AbstractWireProtocolTestWithSnowflake.java
Outdated
Show resolved
Hide resolved
wren-tests/src/test/java/io/wren/testing/snowflake/AbstractWireProtocolTestWithSnowflake.java
Outdated
Show resolved
Hide resolved
wren-tests/src/test/java/io/wren/testing/snowflake/AbstractWireProtocolTestWithSnowflake.java
Show resolved
Hide resolved
grieve54706
force-pushed
the
feature/snowflake-data-source
branch
from
316540c to
851bc81
Compare
goldmedal
reviewed
Apr 18, 2024
| { | ||
| try { | ||
| BigQueryMetadata metadata = getInstance(Key.get(BigQueryMetadata.class)); | ||
| BigQueryClient bigQueryClient = metadata.getBigQueryClient(); |
There was a problem hiding this comment.
There are a bug. We will create a pg_catalog in BigQuery. We should remove it after test.
bigQueryClient.dropDatasetWithAllContent(DatasetId.of(getDefaultCatalog(), metadata.getPgCatalogName()));
There was a problem hiding this comment.
It was lost due to #528. I will add a commit to fix it.
grieve54706
force-pushed
the
feature/snowflake-data-source
branch
from
725f5a6 to
0633f41
Compare
grieve54706
force-pushed
the
feature/snowflake-data-source
branch
from
0633f41 to
c352db5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We implement the
Snowflakedata source. We also usesqlglotto help us handle some statement cases.We don't use Snowflake recommend lib
snowpark, because it has too many features we don't need. We usesnowflake-jdbcinstead it.The snowflake-jdbc includes
Apache-arrowwith a compatibility problem(See https://arrow.apache.org/docs/java/install.html#java-compatibility). Must add arg--add-opens=java.base/java.nio=ALL-UNNAMED.We found the Snowflake SQL if you make the identifiers not delimited, Snowflake will upper-case the identifier name.
The same as before, we don't pay for Snowflake to own an account to test. So we exclude the test cases about Snowflake.
TODO