Skip to content

Upgrade to Java 21 and airbase 153 #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 8, 2024
Merged

Upgrade to Java 21 and airbase 153 #519

merged 7 commits into from
Apr 8, 2024

Conversation

goldmedal
Copy link
Contributor

@goldmedal goldmedal commented Apr 3, 2024

Description

  • Upgrade the airbase version to 153
  • Upgrade JDK to 21
  • Change the base docker image from Zulu to Temurin.
  • Although airlift is migrating from TestNG to JUnit, we won't follow suit in this PR. Because JUnit lacks something akin to DataProvider, which is heavily utilized in wren engine testing, it's challenging to migrate to JUnit at this time.

@goldmedal goldmedal marked this pull request as ready for review April 8, 2024 03:47
@goldmedal goldmedal requested a review from grieve54706 April 8, 2024 03:48
@grieve54706
Copy link
Contributor

grieve54706 commented Apr 8, 2024

Do we will create an issue to make all tests with JUnit? JUnit5 has @ParameterizedTest that could be helpful.

@goldmedal
Copy link
Contributor Author

Do we will create an issue to make all tests with JUnit? JUnit5 has @ParameterizedTest that could be helpful.

The style of ParameterizedTest is very different from DataProvider. I'm not sure that it's a good idea to use it.

Do they have a new code-style schema? I found some import order and import.* is different.

I'm not sure but I didn't import any new schema.

@grieve54706
Copy link
Contributor

The style of ParameterizedTest is very different from DataProvider. I'm not sure that it's a good idea to use it.

If we want to follow the airbase, maybe using the same test framework is a good choice.

@goldmedal
Copy link
Contributor Author

The style of ParameterizedTest is very different from DataProvider. I'm not sure that it's a good idea to use it.

If we want to follow the airbase, maybe using the same test framework is a good choice.

Sure, let's create an issue for it.

@goldmedal goldmedal force-pushed the chore/upgrade-airbase branch from 73402e6 to b9b352c Compare April 8, 2024 08:05
@goldmedal goldmedal mentioned this pull request Apr 8, 2024
@goldmedal
Copy link
Contributor Author

Related issue: #520

@goldmedal goldmedal merged commit 9ab02be into main Apr 8, 2024
3 checks passed
@goldmedal goldmedal deleted the chore/upgrade-airbase branch April 8, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants