Skip to content

chore(mcp): move to v3 query api #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025
Merged

Conversation

goldmedal
Copy link
Contributor

@goldmedal goldmedal commented Mar 26, 2025

Using the v3 API instead of v2.

Summary by CodeRabbit

  • Chores
    • Updated the integration for executing SQL queries to use the latest API endpoint version.

@goldmedal goldmedal requested a review from douenergy March 26, 2025 06:59
Copy link

coderabbitai bot commented Mar 26, 2025

Walkthrough

The change updates the URL endpoint within the make_query_request function in mcp-server/app/wren.py. The version segment of the URL is modified from v2 to v3 for executing SQL queries via an HTTP POST request. No other aspects of the request such as structure, headers, or error handling were altered.

Changes

File(s) Change Summary
mcp-server/app/wren.py Updated the API endpoint from version v2 to v3 in the make_query_request function.

Sequence Diagram(s)

sequenceDiagram
    participant App as Application
    participant API as Wren Engine API (v3)
    App->>API: HTTP POST Query Request (/v3/...)
    API-->>App: Response
Loading

Poem

In my burrow of bytes, a change so neat,
From v2 hops to v3—what a treat!
Queries scurry with a brand new zing,
Each HTTP jump makes our code sing.
Long live the leap, in this rabbit’s beat!
🥕 Hop on, dear developers, let progress greet!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c8ceca4 and 9eba6cd.

📒 Files selected for processing (1)
  • mcp-server/app/wren.py (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: ci
🔇 Additional comments (1)
mcp-server/app/wren.py (1)

44-44:

❓ Verification inconclusive

API version migration looks good, but consider updating other endpoints as well

The update from v2 to v3 for the query API endpoint aligns with the PR objective. The change is straightforward and maintains the same request structure.

I notice that while the query endpoint is being migrated to v3, the metadata endpoints at lines 63 and 77 still use v2. Is this intentional? If v3 offers improved features or stability for all endpoints, consider updating those as well for consistency.


🏁 Script executed:

#!/bin/bash
# Verify if other endpoints have v3 equivalents in the codebase
grep -n "v2/connector" mcp-server/app/wren.py

Length of output: 218


Action: Verify consistency of API versions for all endpoints

The migration of the query endpoint to use the v3 API is correctly implemented on line 44:

  • f"http://{WREN_URL}/v3/connector/{data_source}/query?dry_run={dry_run}"

However, the metadata endpoints remain on v2 at:

  • Line 63: f"http://{WREN_URL}/v2/connector/{data_source}/metadata/tables"
  • Line 77: f"http://{WREN_URL}/v2/connector/{data_source}/metadata/constraints"

Please review whether these metadata endpoints should also be updated to v3 for consistency—especially if the newer version provides improved features or stability. If keeping them on v2 is intentional, consider adding a brief comment to clarify the reasoning for future maintainability.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@douenergy douenergy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @goldmedal

@douenergy douenergy merged commit 5bb54e1 into Canner:main Mar 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants