-
Notifications
You must be signed in to change notification settings - Fork 81
chore(ibis): add function list for DuckDB #1099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ibis): add function list for DuckDB #1099
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
a little bit duckling sql SELECT
function_type,
function_name,
return_type: case when return_type.contains('[]') then 'array'
else return_type.lower() end,
parameter_names: parameters.aggregate('string_agg'),
parameter_types: case when parameter_types.aggregate('string_agg').contains('[]') then 'array'
else parameter_types.aggregate('string_agg').lower() end,
description
FROM duckdb_functions()
WHERE function_type in ('scalar', 'aggregate')
and function_name not like '%__internal%'
and function_name.regexp_matches('[_a-zA-Z0-9]+'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good , just one small comment
response = await client.get(url=f"{base_url}/functions") | ||
assert response.status_code == 200 | ||
result = response.json() | ||
assert len(result) == DATAFUSION_FUNCTION_COUNT + 438 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a comment explaining where the number 438 comes from.
Thanks @goldmedal ! |
Description
The following SQL in DuckDB builds the function list: