Skip to content

Change the default landing page and make it a command-line option #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2024
Merged

Change the default landing page and make it a command-line option #56

merged 1 commit into from
Feb 8, 2024

Conversation

stargaser
Copy link
Collaborator

@stargaser stargaser commented Jan 19, 2024 •
edited
Loading

This PR is for the filetable.py example script.

  • Change the default html_file for Firefly to "firefly.html" (the triview)
  • Make the html_file a command-line option in case a user wants Slate or something else

@stargaser
Copy link
Collaborator Author

The triview doesn't have the "flashing" problem that we saw on Safari with Slate. Overall it seems better behaved and is more configurable.

robyww
robyww approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine. Rubin does not use this script so I don't think anyone will object.

@stargaser stargaser merged commit 3f86f33 into master Feb 8, 2024
@stargaser stargaser deleted the filetable-triview branch February 8, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robyww robyww robyww approved these changes

@gpdf gpdf Awaiting requested review from gpdf

@jaladh-singhal jaladh-singhal Awaiting requested review from jaladh-singhal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stargaser @robyww