-
Notifications
You must be signed in to change notification settings - Fork 7
Update filetable.py example to make it work #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
de57cd4
to
4a1c05c
Compare
* add pause before uploading table * add FIREFLY_URL environment variable as the default * print a message while files are being pattern-matched * reformat single-quotes to double-quotes
4a1c05c
to
bb77c5c
Compare
I'm using this to do some work for NEO Surveyor (my new position) and found a number of updates were needed. |
In general I think the documentation for the main() should probably include an explanation that this whole thing only works if the same directory is mounted/visible on the Firefly server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stargaser it works great! I tested it with a local firefly server with both printurl disabled and enabled. Left minor comments, then it's ready to merge.
Also I liked that I could understand what this script does using python filetable.py --help
. We should maybe document this script example in README (not necessarily in this PR though)
Co-authored-by: Jaladh Singhal <[email protected]>
I think you could address this in |
I've added extended help to the description and the epilog. Would be great if either or both of @jaladh-singhal or @gpdf could try out |
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you! Looks good.
--printurl
is specified