Dm 11476 Make demo sample to create charts with plot.ly #15

cwang2016 · 2017-08-09T19:43:41Z

The development includes:

add function show_plot to show chart with plot.ly
add function show_fits_3color to show 3 color fits by giving target and band information.
update function show_table to find catalog table by either giving file name on the server or the target search information.
change remote action request by using 'POST' request.
add demo sample 'slate-demo-explicit2.ipynb' which renders table, image and various charts with plot.ly

Test:
update firefly first
Open 'slate-demo-explicit2.ipynb' from jupyter notebook and run the code cells.

…odify show_table to get table by giving target search info, and add demo sample likr ffapi-slate-test2.html for plot.ly direct plot.

stargaser · 2017-08-09T21:03:21Z

examples/slate-demo-explicit2.ipynb

+   "cell_type": "markdown",
+   "metadata": {},
+   "source": [
+    "## Dispaly tables, images, and charts in Window/Grid like layout\n",


Dispaly -> Display

tgoldina

Works similar to JS version, just like it should.

tgoldina · 2017-08-09T22:10:21Z

examples/slate-demo-explicit2.ipynb

+    "        'zaxis': {\n",
+    "            'title': 'w1mpro'\n",
+    "        }\n",
+    "    }\n",


The layout object for 3d should be wrapped into scene - so that the labels are applied to the 3d axes:

layout3d = { 'scene': { 'xaxis': { 'color': 'red', 'title': 'ra', 'showline': True }, 'yaxis': { 'color': 'blue', 'title': 'dec', 'showline': True }, 'zaxis': { 'color': 'green', 'title': 'w1mpro', 'showline': True } } }

However, there are still things to fix in firefly, so that scatter3d is not considered to be a scatter plot, and the default layout is not applied to it. I am planning to do it in a separate ticket.

…scatter3d case.

tgoldina · 2017-08-10T16:28:12Z

3d plot looks great now! Setting visible to false for external axes as a workaround for Firefly issues works great.

robyww

Looks good. 3d updated are very nice. Make sure you put them back into ffapi-slate-test2.html in the firefly repository.

cwang2016 · 2017-08-10T16:53:16Z

Update the chart content for 'slate-demo-explicit2.ipynb' on WISE as follows,
2D scatter: w1-w2 and w2-w3 for x and y
heatmap: 3 sets, w1 vs. w2, w1 vs. w3, and w1 vs. w34.
histogram: 2 sets, w1, w2.
3D scatter: w1, w2, w3 for x, y, z.

…-demo-expliit2, and update the image in sync with Firefly grid-view samples.

stargaser

The notebooks are much improved, very nice! M31 three-color looks great with WISE at 1 degree.

In addition to line comments on the "explicit2" notebook, here are some more comments I couldn't make on "explict" because the modifications were made in an earlier PR:

line 84 -- typo in Dispaly

In the code cells: these start with summary comments that explain what is happening in that cell. The notebook would be easier to read if these summary comments were moved to Markdown cells before the corresponding code cells.

The last code cell shows "random" placement. This confused me the first few times. I think it is better to replace "random" with "unspecified" and say that Firefly places the cell. Some of the confusion is caused by the the coverage image being width=3. Then Firefly puts this last image in the next column with blank space from the WISE Cutout image. If I make coverage have width=2, then Firefly decides to put the last image in a new row. Anyway, it is confusing to make the coverage width=3 when that leaves a lot of empty space in that cell.

stargaser · 2017-08-11T16:49:23Z

examples/slate-demo-explicit.ipynb

+   "execution_count": null,
+   "metadata": {
+    "collapsed": false
+   },


It would be helpful to insert a Markdown cell above this one, explaining what reinit_viewer() does. It seems to be different than reloading the browser window (clearing everything).

stargaser · 2017-08-11T17:56:12Z

examples/slate-demo-explicit2.ipynb

+   },
+   "outputs": [],
+   "source": [
+    "target = '10.68479;41.26906;EQ_J2000'\n",


I suggest to add a hint about what the objects are, and to add a Galactic star-forming region, like this:

target = '10.68479;41.26906;EQ_J2000' # Galaxy M31 # other notable targets to try #target = '148.88822;69.06529;EQ_J2000' # Galaxy M81 #target = '202.48417;47.23056;EQ_J2000' # Galaxy M51 #target = '136.9316774;+1.1195886;galactic' # W5 star-forming region

stargaser · 2017-08-11T17:57:48Z

examples/slate-demo-explicit2.ipynb

+   "cell_type": "markdown",
+   "metadata": {},
+   "source": [
+    "Entering a target to search the catalog and image"


Please add here: the coordinates are in decimal hours and decimal degrees for EQ_J2000. The Galactic coordinates are in degrees.

stargaser · 2017-08-11T17:59:50Z

examples/slate-demo-explicit2.ipynb

+   ]
+  },
+  {
+   "cell_type": "code",


Add a Markdown cell before this one including:

All plots are added in one notebook cell to better simulate an application

Before re-executing this cell (perhaps with a different target selected), reload the Firefly browser window to clear out the existing plots.

stargaser · 2017-08-11T18:03:11Z

examples/slate-demo-explicit2.ipynb

+    "                {'dataType': 'fireflyHeatmap'},\n",
+    "                {'dataType': 'fireflyHeatmap'},\n",
+    "                {'dataType': 'fireflyHeatmap'}]\n",
+    "    layout_hm = {'title': 'Photometry heatmap', \n",


A better title is "Magnitude-magnitude densities'

…rt due to the 3d bugs fixing in firefly.

stargaser · 2017-08-11T18:30:53Z

I forgot one more point. It would be really nice in the 3-color plot to change the transparency of the marks so they don't obliterate the image -- like a transparency of 30%. I think I've done this with the JS API before.

…show_plot based on Firefly update for plotly chart.

cwang2016 · 2017-08-11T21:53:54Z

Regarding changing transparency for the maker, currently no firefly_client API supports that capability. we may create that later as needed.

stargaser · 2017-08-11T22:28:51Z

I have re-reviewed. Looks good to me!

Cindy Wang added 2 commits August 8, 2017 18:50

DM-11476 add functions add_plot, reinit_viewer, add_fits_3color and m…

c4b7bc1

…odify show_table to get table by giving target search info, and add demo sample likr ffapi-slate-test2.html for plot.ly direct plot.

DM-11476 some update for 3D plot rendering.

930d0ff

cwang2016 requested review from tgoldina, stargaser and robyww and removed request for tgoldina August 9, 2017 19:43

stargaser reviewed Aug 9, 2017

View reviewed changes

tgoldina approved these changes Aug 9, 2017

View reviewed changes

Cindy Wang added 3 commits August 9, 2017 18:35

DM-11476 change thecontent for each chart and fix the axis title for …

bb604ec

…scatter3d case.

DM-11476 update the layout setting for scatter3d chart with plot.ly.

b24de81

DM-11476 add chart title

edee6bb

robyww approved these changes Aug 10, 2017

View reviewed changes

Cindy Wang added 2 commits August 10, 2017 09:58

DM-11476 fix typo in comment.

d0efa75

DM-11476 update chart content and decoration of grid-view demo, slate…

5f18f4b

…-demo-expliit2, and update the image in sync with Firefly grid-view samples.

cwang2016 mentioned this pull request Aug 11, 2017

DM-11556 Update chart content of grid-view sample, ffapi-slate-test2.html Caltech-IPAC/firefly#440

Merged

stargaser approved these changes Aug 11, 2017

View reviewed changes

DM-11476 remove the workaround to remove the external axes for 3d cha…

df8c532

…rt due to the 3d bugs fixing in firefly.

DM-11476 fix the notebook files based per review comments and update …

ee1ab3a

…show_plot based on Firefly update for plotly chart.

cwang2016 merged commit 9911536 into master Aug 11, 2017

cwang2016 deleted the DM-11476-pythonplotly branch August 11, 2017 22:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Dm 11476 Make demo sample to create charts with plot.ly #15

Dm 11476 Make demo sample to create charts with plot.ly #15

Uh oh!

cwang2016 commented Aug 9, 2017 •

edited

Loading

Uh oh!

stargaser Aug 9, 2017

Uh oh!

tgoldina left a comment

Uh oh!

tgoldina Aug 9, 2017

Uh oh!

tgoldina commented Aug 10, 2017

Uh oh!

robyww left a comment

Uh oh!

cwang2016 commented Aug 10, 2017

Uh oh!

stargaser left a comment

Uh oh!

stargaser Aug 11, 2017

Uh oh!

stargaser Aug 11, 2017

Uh oh!

stargaser Aug 11, 2017

Uh oh!

stargaser Aug 11, 2017

Uh oh!

stargaser Aug 11, 2017

Uh oh!

stargaser commented Aug 11, 2017

Uh oh!

cwang2016 commented Aug 11, 2017

Uh oh!

stargaser commented Aug 11, 2017

Uh oh!

Uh oh!

Dm 11476 Make demo sample to create charts with plot.ly #15

Dm 11476 Make demo sample to create charts with plot.ly #15

Uh oh!

Conversation

cwang2016 commented Aug 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stargaser Aug 9, 2017

Choose a reason for hiding this comment

Uh oh!

tgoldina left a comment

Choose a reason for hiding this comment

Uh oh!

tgoldina Aug 9, 2017

Choose a reason for hiding this comment

Uh oh!

tgoldina commented Aug 10, 2017

Uh oh!

robyww left a comment

Choose a reason for hiding this comment

Uh oh!

cwang2016 commented Aug 10, 2017

Uh oh!

stargaser left a comment

Choose a reason for hiding this comment

Uh oh!

stargaser Aug 11, 2017

Choose a reason for hiding this comment

Uh oh!

stargaser Aug 11, 2017

Choose a reason for hiding this comment

Uh oh!

stargaser Aug 11, 2017

Choose a reason for hiding this comment

Uh oh!

stargaser Aug 11, 2017

Choose a reason for hiding this comment

Uh oh!

stargaser Aug 11, 2017

Choose a reason for hiding this comment

Uh oh!

stargaser commented Aug 11, 2017

Uh oh!

cwang2016 commented Aug 11, 2017

Uh oh!

stargaser commented Aug 11, 2017

Uh oh!

Uh oh!

cwang2016 commented Aug 9, 2017 •

edited

Loading