Skip to content

IRSA-3009: Table sort wrongly interpret proprietary data #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

loitly
Copy link
Contributor

@loitly loitly commented Aug 7, 2019

https://jira.ipac.caltech.edu/browse/IRSA-3009

In tables with proprietary data, it failed to interpret row access beyond first page. This is due to startIdx not being passed to the table rendering logic.

To test, follow the instructions from the ticket.
Test build: https://irsawebdev9.ipac.caltech.edu/IRSA-3009_sort_proprietary_rows/applications/sofia/

@loitly loitly requested a review from ejoliet August 7, 2019 20:32
@loitly loitly self-assigned this Aug 7, 2019
Copy link
Contributor

@ejoliet ejoliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fixed. Thanks!

@loitly loitly merged commit 6324190 into dev Aug 8, 2019
@loitly loitly deleted the IRSA-3009_sort_proprietary_rows branch August 8, 2019 18:07
@robyww robyww added bug Table Changes to table or table model labels Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Table Changes to table or table model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants