Skip to content

FIREFLY-172: put back read from URL in VoTableReader #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

loitly
Copy link
Contributor

@loitly loitly commented Aug 5, 2019

https://jira.ipac.caltech.edu/browse/FIREFLY-172
Test: https://irsawebdev9.ipac.caltech.edu/FIREFLY-172_sofia_table_stopped_working/applications/sofia/

Additional changes here: https://github.com/IPAC-SW/irsa-ife/pull/78

  • put back the ability to read VOTable from URL.
  • revert changes to SofiaQuery made as a workaround to previous changes

Also

  • set higher logging level for starlink to avoid repetitive warning messages

- set higher logging level for starlink to avoid repetitive warning messages
@loitly loitly self-assigned this Aug 5, 2019
@loitly loitly requested a review from deannaji August 5, 2019 18:39
Copy link
Contributor

@deannaji deannaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks :)

@loitly loitly merged commit 3dd2439 into dev Aug 6, 2019
@loitly loitly deleted the FIREFLY-172_sofia_table_stopped_working branch August 6, 2019 21:27
@robyww robyww added bug Table Changes to table or table model labels Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Table Changes to table or table model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants