FIREFLY-162: fixed download feature not working in firefox and safari #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also, minor tweaked to File Upload layout
|
Yes, I confirm that it works for me on Firefox now. |
ejoliet
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.ipac.caltech.edu/browse/FIREFLY-162
Test link: https://irsawebdev9.ipac.caltech.edu/FIREFLY-162_save_firefox_safari/firefly/
As reported in ticket, downloading is no longer working in Firefox and Safari.
This is due to a recent chance in the code where the
<A>tag was not added to the HTML document before triggering a click event. Not testing it in Firefox and Safari was an oversight.You should definitely test the fix in all browsers. :)