Skip to content

FIREFLY-158_uplaod_panel_buttons_are_too_down_in_ts #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2019
Merged

FIREFLY-158_uplaod_panel_buttons_are_too_down_in_ts #836

merged 1 commit into from
Jul 22, 2019

Conversation

deannaji
Copy link
Contributor

@deannaji deannaji commented Jul 17, 2019 •
edited
Loading

The buttons in the upload panel were down to the bottom in Time Series application.

Jira: https://jira.ipac.caltech.edu/browse/FIREFLY-158
K8s: https://irsawebdev9.ipac.caltech.edu/firefly-158/irsaviewer/timeseries

@deannaji deannaji requested review from ejoliet, loitly and lznakano July 17, 2019 21:30
@deannaji deannaji self-assigned this Jul 17, 2019
lznakano
lznakano approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@lznakano lznakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good!!

@ejoliet ejoliet mentioned this pull request Jul 18, 2019
Closed
ejoliet
ejoliet approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@ejoliet ejoliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fixed! Thanks

loitly
loitly approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@loitly loitly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works. Go ahead.

@deannaji deannaji merged commit f397d39 into dev Jul 22, 2019
@deannaji deannaji deleted the FIREFLY-158_uplaod_panel_buttons_are_too_down_in_ts branch July 22, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejoliet ejoliet ejoliet approved these changes

@loitly loitly loitly approved these changes

@lznakano lznakano lznakano approved these changes

Assignees

@deannaji deannaji

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deannaji @ejoliet @loitly @lznakano