Firefly-91: Add centering drop down menu #831

robyww · 2019-06-28T18:23:48Z

Firefly-91: Add centering drop down menu

Center on target
Center on image
Add drop down
Modified for brief target panel / cleaned up target panel
Added recent cascade
CompleteButton will now optionally respond to enter
10 Recent targets saved as a preference
added start up option support
added watcher to center image on table row

to test:

https://irsawebdev9.ipac.caltech.edu/firefly-91-center-dropdown/firefly/

Load a HiPS (or image but HiPs makes for a better test)
- Goto the Center dropdown
- Try Center on target (will be enable if you entered a target)
- click on the position input and try positions, watch HiPS move
- look to see if it saves your recent positions
Load two catalogs from two different positions
- click on various rows of the table and see the hips move to the position

- Center on target - Center on image - Add drop down - Modified for brief target panel / cleaned up target panel - Added recent cascade - CompleteButton will now optionally respond to enter - 10 Recent targets saved as a preference - added start up option support - added watcher to center image on table row

cwang2016 · 2019-06-28T22:07:59Z

The centering dropdown menu looks good and works well.

I may not understand all functions of the dropdown menu well, here are a few questions,

if doing image search (not hips) and catalog search and 'pan by table row' is checked, how is the image affected when the table highlight (or select) changs? I see the change on hips, but not very sure about the change on fits image.
-'center on target' and 'center on image' on the menu looks active for fits image, and grey out for hips image. what are the usage of those two items as shown on the menu?
when we do hips search, if no target is given, the hips is centered at 0,0 in default, should the dropdown menu shows '0, 0' at 'Center On' when the centering button is clicked after such hips search?

ejoliet

This is so cool! I've played with it and didn't find any problem. I really liked the recent position too!

I've tried the 'pan by row' on a table catalog, and it's awesome!

Great job!!!

robyww · 2019-06-28T22:54:08Z

I may not understand all functions of the dropdown menu well, here are a few questions,

if doing image search (not hips) and catalog search and 'pan by table row' is checked, how is the image affected when the table highlight (or select) changs? I see the change on hips, but not very sure about the change on fits image.

The image will only move if the new target in outside of 90% of the screen.

'center on target' and 'center on image' on the menu looks active for fits image, and grey out for hips image. what are the usage of those two items as shown on the menu?

'center on target' is not grayed out if you entered a target, you probably did not.

'center on image' is always grayed out for image since it does not makes sense for HiPS.

when we do hips search, if no target is given, the hips is centered at 0,0 in default, should the dropdown menu shows '0, 0' at 'Center On' when the centering button is clicked after such hips search?

It could, we can ask the scientist.

vandesai1 · 2019-07-01T22:58:12Z

when I hover over the the words "Center on Target" or "Center on Image" or "Recent Positions", they get highlighted in white.
when I put in a position that is not on a FITS image, and then recenter the FITS image, the old position is still in the input box, which could lead people to think that position is now centered. Probably just get rid of it at that point?
if I open a HiPS image with the target "Arp220", and then open the "center on" menu, I see "0,0" in the position, making me think that's where the image is centered. Would be nice if somehow the dialog could tell you where you are currently centered, or go blank. Related to comment above.

Otherwise, this looks really good!

gpdf · 2019-07-02T01:29:47Z

@cwang2016 wrote:

when we do hips search, if no target is given, the hips is centered at 0,0 in default, should the dropdown menu shows '0, 0' at 'Center On' when the centering button is clicked after such hips search?

HiPS maps may come with an initial position and FOV that is used as the default. It would be nice to offer the user the ability to go back to that point through this new menu. (I can't recall, does the master "reset" button do that when used on a HiPS image?)

gpdf · 2019-07-02T01:33:25Z

@robyww wrote:

added start up option support

What is this?

gpdf

In general this is wonderful progress.

I cannot approve it for release until we've decided what to do about the "fiducial region" issue and the "click on catalog symbol on image" behavior mentioned elsewhere in this review. I suggest we discuss this in person tomorrow (Tuesday July 2nd) if enough people are available.

gpdf · 2019-07-02T01:43:35Z

src/firefly/js/visualize/ui/ImageCenterDropDown.jsx

+                           horizontal={false} key={'center-search-target'}
+                           onClick={() => dispatchRecenter({plotId})} />
+
+            <ToolbarButton text='Center on Image' tip='Center on the image'


I think "Center Image" with tooltip "Center image in display frame" would be grammatically and UX-ish better than "Center on Image".

The full sentence for "Center on Target" (which is fine!) would be something like "Center the selected image on (some) target". By parallel construction, then, it "feels like" "Center on Image" is saying something like "Center the selected image on (some) image". Every time I read it I find my brain saying "on what image?", and even though the answer is obvious on reflection, I think it still creates some friction.

Just let me know what the tip should be and I will set it to that.

Just as in the first sentence above. The rest of the comment was a rationale.

gpdf · 2019-07-02T01:50:48Z

src/firefly/js/visualize/ui/ImageCenterDropDown.jsx

+            <FieldGroup style={{display:'flex', fontSize:'10pt', padding:'5px 0 0 0'}}
+                        groupKey='TARGET_DROPDOWN' validatorFunc={null} keepState={true}>
+                <TargetPanel groupKey={'target-move-group'} labelWidth={80}
+                             label={'Center On:'}


What a great feature!

One small thing: whenever I use "Center On" I feel like it would be natural for some kind of visual mark to appear on the display in the selected location, e.g., a crosshair icon, in the selected position.

If I can do this in a couple of hours I will, but this probably needs to be a separate ticket.

OK- I can get the basic functionality working. I will use our existing symbols though. We can enhance it later.

(Just for the record, @robyww went even further and created an actual Firefly "marker" from the entered position.)

gpdf · 2019-07-02T02:32:43Z

src/firefly/js/visualize/ui/ImageCenterDropDown.jsx

+            <DropDownVerticalSeparator useLine={true}/>
+
+
+            <ToolbarButton text='Center on Target' tip='Center on search target'


Trying to come to this with a blank slate, I found it confusing to think about what the user will understand as a/the "target" or even "search target". It is very easy to imagine a user thinking of what they typed in the "Center On..." field as a "target".

What is really is, I think, is the name or coordinates most recently used in an image or catalog search, is that right? Let's see if we can think of a way to make that clearer.

Just let me know what the text should be and I will set it to that.

I do not have an actionable suggestion for now. We can address this in a future ticket if the CCB-D has a good idea.

src/firefly/js/visualize/ui/ImageCenterDropDown.jsx

gpdf · 2019-07-02T02:37:51Z

src/firefly/js/visualize/ui/ImageCenterDropDown.jsx

+    const dropDown= (
+        <SingleColumnMenu>
+
+            <ToolbarButton text='Pan by table row' tip='Center selected images position of the highlighted row'


It looks to me like the original specification that there be a "fiducial region" of the displayed image within which no panning would occur was not, in the end, followed.

I still think this is important to avoid excessive panning and even possibly confusing behavior.

It is also pretty important, now that I'm playing with this, for no panning to occur in response to clicking on the displayed mark on the image for a table row. This produces an unsettling effect, plays poorly with "lock by click", and makes the UX very sensitive to whether the user hits the symbol exactly or just off by a little.

On FITS or zoomed in HiPS not panning occurs if the object object in with in 90% of the displayed area. Zoom out hips do pan. I think this makes a little more sense.

However, I did not test clicking on the image or HiPS. I agree that in that case is should never jump. I am fixing that.

CCB-D agrees, after experience with the tool, that we should abandon the idea of the "fiducial region". The behavior of "pan to table row" should be to move the image only when necessary to make the selected row's symbol visible.

robyww · 2019-07-02T15:47:16Z

. (I can't recall, does the master "reset" button do that when used on a HiPS image?)

The reset button moves HiPS to the original position and size.

robyww · 2019-07-02T18:41:37Z

when I hover over the the words "Center on Target" or "Center on Image" or "Recent Positions", they get highlighted in white.

I don't think I understand this one.

when I put in a position that is not on a FITS image, and then recenter the FITS image, the old position is still in the input box, which could lead people to think that position is now centered. Probably just get rid of it at that point?

OK- I think it makes sense to clear it. I will do that.

if I open a HiPS image with the target "Arp220", and then open the "center on" menu, I see "0,0" in the position, making me think that's where the image is centered. Would be nice if somehow the dialog could tell you where you are currently centered, or go blank. Related to comment above.

Yes, I think going blank makes most sense.

- optionally a marker when center request - clear the target panel - click on point without the image jumping - recent position tool tips now have more information - tool tip and title for some dropdowns - images re-centers only if point off the image Off Ticket: - Make HipsUtil smarter about computing the max hips depth - fixed dropdown opening in visible area, when too far right

robyww requested review from ejoliet, gpdf, cwang2016 and vandesai1 June 28, 2019 18:23

robyww self-assigned this Jun 28, 2019

ejoliet approved these changes Jun 28, 2019

View reviewed changes

robyww force-pushed the firefly-91-center-dropdown branch from 8423242 to ea092d6 Compare July 1, 2019 21:04

gpdf requested changes Jul 2, 2019

View reviewed changes

robyww force-pushed the firefly-91-center-dropdown branch from c5097ad to 78148cd Compare July 3, 2019 00:12

robyww merged commit 8fd5b0c into dev Jul 3, 2019

robyww deleted the firefly-91-center-dropdown branch July 3, 2019 00:14

robyww added enhancement overlay-drawing overlay drawing for images or HiPS HiPS HiPS work Image FITS images labels Oct 30, 2019

		<DropDownVerticalSeparator useLine={true}/>


		<ToolbarButton text='Center on Target' tip='Center on search target'

Firefly-91: Add centering drop down menu #831

Firefly-91: Add centering drop down menu #831

Uh oh!

Conversation

robyww commented Jun 28, 2019

Uh oh!

cwang2016 commented Jun 28, 2019

Uh oh!

ejoliet left a comment

Choose a reason for hiding this comment

Uh oh!

robyww commented Jun 28, 2019

Uh oh!

vandesai1 commented Jul 1, 2019

Uh oh!

gpdf commented Jul 2, 2019

Uh oh!

gpdf commented Jul 2, 2019

Uh oh!

gpdf left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

robyww commented Jul 2, 2019

Uh oh!

robyww commented Jul 2, 2019

Uh oh!

Uh oh!