FIREFLY-59: Filtering fail when value contains semicolon

[loitly]

ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-59
test: https://irsawebdev9.ipac.caltech.edu/FIREFLY-59/firefly/firefly-dev.html

As reported, filtering fail when the value contains semicolon. Because we were using semicolon to separate conditions, this messes up the underlying query statement.

Instead of just fixing the problem, I went ahead and allow the conditions delimiter to be either AND or OR. Although this added a useful requested feature, it also may require updates to our online help. Please coordinate with the appropriate people after merging.

Sample conditions:
> 0 and < 50 or is NULL
< 0 or > 100
in ('m31', 'm41') or is NULL

[vandesai1]

Just tried it. Looks good.

[xiuqin]

Definitely a good improvement using 'AND' 'OR' for conditions. This was something we wanted to add for some time. I see that the tooltip has been changed to reflect this new capability. Great job!

[cgelino]

Confirmed that AND and OR filtering works as expected. Semicolon filters do not work as expected.

A couple of unrelated things:

1. I couldn't query the NEOWISE-R Single Exposure DB. This is also a problem on ops, so I'll send IRSA a ticket.
2. Putting a string in double quotes instead of single quotes has some weird consequences. Sometimes the string is ignored (is "blah" -> is NULL) and sometimes it tries to be parsed as is (= "blah" -> ='"blah"').

[Olga9999]

I was testing test case from FF-59 JIRA ticket for the dealing with semicolon in the UCD column of the
Gaia tap service table.
It works.

[loitly]

2. Putting a string in double quotes instead of single quotes has some weird consequences. Sometimes the string is ignored (is "blah" -> is NULL) and sometimes it tries to be parsed as is (= "blah" -> ='"blah"').

• is and is not can only be used with NULL. That's why auto-correct replace everything after that with NULL. This is something I am not sure of. I can either auto-correct, or let is error out when it's not NULL.
• String literal must be enclosed in single-quotes. When it's not, auto-correct will add it.

[ejoliet]

I played with it and it’s a great and helpful improvement! Also noticed updated test! Thanks also for updating the tooltip! Awesome!

Good to be merged.