IRSA-2894: ZTF images flipped east-west in time series tool #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will build IRSAViewer so we can test it with different images from different projects. |
|
Version to test is deployed here: https://irsawebdev9.ipac.caltech.edu/irsa-2894/irsaviewer/ |
cgelino
approved these changes
Jun 12, 2019
There was a problem hiding this comment.
I displayed ZTF Reference images side by side with WISE images of the same field and do not see any axis flipping issues. I also tried some of my local images with WCS and they are displayed fine.
During test I found a different bug, not related to ZTF (it's on ops as well).
- in the IRSA Viewer, do a search on position "00 38 29.05 +27 58 52.1" in WISE (W1 & W2) and SDSS (r & z). There are WISE data but no SDSS data at this position.
- WCS match the frames and set the display to single image (I don't know if it matters, but I also had North up).
- Run the autoplay to cycle through the images.
- after the 2nd SDSS frame (there is nothing there, of course), the entire IRSA Viewer crashes and the only thing left in the browser is the top IRSA tool bar.
- NOTE: I tried 1 WISE and 1 SDSS (no problem), 1 WISE and 2 SDSS (no problem), 2 WISE and 1 SDSS (site crash)
|
@slgroom noticed that in the magnifier view, the compass has the wrong orientation in ZTF images. I'll try to apply the same fix to |
|
A few other things I should have noted before.
|
|
Thanks.
I've also noticed that and the fact that the compass is positioned randomly too, when it should stay in upper corner or any place consistently in the image frame.
Those interactions/issues related to WCS match and lock are probably going to change because of FIREFLY-75 updates - see #825 . |
|
- Seems to me that the compass was positioned on some part of the *image*,
not the *display*. so after zoom etc, it may go out of view. Would
be better to just park it in some corner of the *display* and
leave it there, not pan/zoom with the image.
- when wcs-match gets turned off, images should stay as they are, they should not
instantly change rotation/position/zoom when match is switched off. I know there
is some confusion about meaning of match vs lock, but when we turn off match
please don't change the layout.
… On Jun 12, 2019, at 2:54 PM, Emmanuel Joliet ***@***.***> wrote:
Thanks.
• The compass rose doesn't always show on the image even if the button in the menu bar indicates that option is active. I haven't been able to figure out how to make it happen reliably. It just seems random.
I've also noticed that and the fact that the compass is positioned randomly too, when it should stay in upper corner or any place consistently in the image frame.
Unfortunately, this happens in OPS so it wasn't introduced in the PR.
I'll make a ticket (minor priority though, compare to others things).
• An image's orientation is reverted back to its original state (North down for ZTF) after turning off WCS matching. This happens even if you put North up prior to the WCS matching. I don't think the image orientations should change when you deactivate WCS matching. I guess I think of a WCS match as a one time action. Whether or not they stay matched after that depends on the user.
• Sort of related to 2). Bring up three images of the same field (M5 is a good one): 2 from ZTF and 1 from WISE. Click on the WISE image to activate and then WCS match the ZTF images to it. The ZTF images are rotated as expected. Turn off the frame "locking" so that each image can move independently. Move one of the ZTF images. Now activate the other ZTF image (the one you did not move). Turn off WCS matching and notice the activated ZTF image is rotated back to the original orientation and the ZTF image that you moved still has North up.
Those interactions/issues related to WCS match and lock are probably going to change because of FIREFLY-75 updates - see #825 .
Will be good to test though.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I've filed ticket FIREFLY-144. |
See ticket https://jira.ipac.caltech.edu/browse/FIREFLY-75 now a PR #825. You are welcome to test it. https://irsawebdev9.ipac.caltech.edu/firefly-75-wcsmatch/firefly/ |
ejoliet
added a commit
that referenced
this pull request
Jun 13, 2019
IRSA-2894: ZTF images flipped east-west in time series tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZTF images are mirror-reversed with respect to the sky, with North down and East to the left. Account for this case by computing the cross product of local North and East vectors, and taking the sign to know when to flip the compass.
Link to ticket in JIRA: https://jira.ipac.caltech.edu/browse/IRSA-2894