FIREFLY-29: inadequate interpretation of the target field value

[tgoldina]

https://jira.ipac.caltech.edu/browse/FIREFLY-29
Test build: https://irsawebdev9.ipac.caltech.edu/firefly-29_tgtresolver/firefly/?__action=layout.showDropDown&visible=true&view=IrsaCatalogDropDown

• Objects with the names starting with a number are now resolved
• Names with long-dash are now resolved (they were previously causing "TypeError: Cannot assign to read only property ..." and "Invariant Violation" warnings in React.
• Show unencoded name for failed name resolutions. (They were previously shown encoded.)

Previously failing, now resolving target names:
61 Ursae Majoris
41 Ara
12 Ophiuchi
39 Leonis
SCR J0630–7643

Known issues:

• The greek symbols are not converted into English equivalent.
• Degree symbol is not stripped.

These are the names resolved by http://cds.u-strasbg.fr/cgi-bin/Sesame, but not by Firefly:
Sk -68°137
ξ UMa
β CVn
χ¹ Ori
δ Eri
κ¹ Cet
ζ Puppis

(from https://en.wikipedia.org/wiki/Lists_of_stars)

Firefly replaces unrecognized non-ascii characters with '?', hence giving user a hint how to change the name so that it gets recognized.

[cgelino]

I tested with OS X 10.11.6, Firefox 67.0.1, Safari 11.1.2, and Chrome 71.0.3578.98. All tests returned results as expected:
-- objects with names starting with a number were resolved properly
-- object names with Greek characters or special symbols were not resolved, but displayed a '?' in place of the special symbol in the informational message to the user.

[Olga9999]

REPORT from olga9999
#822 FireFly-29

https://jira.ipac.caltech.edu/browse/FIREFLY-29

https://irsawebdev9.ipac.caltech.edu/firefly-29_tgtresolver/firefly/?__action=layout.showDropDown&visible=true&view=IrsaCatalogDropDown

1. MacOS 10.14.5
   Browsers:
   FireFox 67.0(64 bit) AND Safari v. 12.1.1

61 Ursae Majoris
41 Ara
12 Ophiuchi
39 Leonis
SCR J0630-7643

• are working fine.

I have tested other names started from the number:
3c279
2MASS J12283266-4315159

• also work.

Sk -68°137
and names with greek letters

• are now working as expected.
  Not really working, but it gives the "?" in proper places after
  "Could not resolve:"

• I did use ops site to compare:
  https://irsa.ipac.caltech.edu/irsaviewer/?__action=layout.showDropDown&visible=true&view=IrsaCatalogDropDown

2. Mac OS 10.10.5
   Browsers:

• FireFox 66.0.5
  all works as described above.
• Safari 10.1.2
  will not open testing site, probably too old.

Thanks,
Olga

[ejoliet]

@cgelino @Olga9999 thanks for testing. Seems everything works and the bug is fixed, could you approve the PR as a formal step? thanks!

[ejoliet]

Is working fine now and acknowledged that greek target name won't work. Good to be merged.
Thank you!

[cgelino]

Looks good. [I put my comment in the wrong box!]

[Olga9999]

It works fine now