FIREFLY-136: Support right justification of numeric columns in Firefly table #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y table display component
ejoliet
approved these changes
Jun 6, 2019
There was a problem hiding this comment.
Looks great!
Minor comment about the test 6: i did noticed that the in_row_id value is always 1, i was expecting different values. I might be confused of what the column should show but if it's row id, shouldn't the value changed per row?
Other than that, it's good to go from my side.
Thanks!
This is "input" row ID. This table must be the results of a single row multi-position search. The values of that column's data is all 1s. It is expected behavior. |
|
Tested by uploading a file and the results look good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.ipac.caltech.edu/browse/FIREFLY-136
Changes:
text.To test:
https://irsawebdev9.ipac.caltech.edu/FIREFLY-136/
Make sure all tables are behaving this way. For links, look at test #6 of this page.
https://irsawebdev9.ipac.caltech.edu/FIREFLY-136/firefly/test/tests-main.html#test-6