Skip to content

IRSA-2442 and IRSA-2742: adding ISSA and 2mass 6 degrees datasets #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 7, 2019

Conversation

ejoliet
Copy link
Contributor

@ejoliet ejoliet commented Jun 4, 2019

This pull request is about adding 2mass 6deg mosaics IRSA-2742 and ISSA image datasets IRSA-2442 to the image search panel.
It fixes FLS 21 cm cube display by removing the cutout (column dataType in the config file set to cube instead of image).
It also fixes couple of problems introduced when adding ZTF (IRSA-2017) and fixes the band id in the master table config file introduced in IRSA-2443 and as a consequence fixing IRSA-2309

The added datasets are not fully working because of some IBE problem that need to be fixed. If by the time of a release, IBE is not fixed, this will need to be removed form the config file and UI.

Deployed version to test IRSA-2442, IRSA-2742: https://irsawebdev9.ipac.caltech.edu/irsa-2442/irsaviewer/
To test FLS: https://irsawebdev9.ipac.caltech.edu/irsa-2442-2309/irsaviewer/

Test guide:

  • For ISSA, try searching m16 or m81.
  • For 2mass 6deg: m31 target example
  • For testing IRSA-2017, cosmos 20cm: use target CGCG 036-024
  • Testing IRSA-2309: search FLS 21 cm, use WN B1718+6023 target

@ejoliet ejoliet requested a review from wmiipac June 4, 2019 00:17
Copy link
Contributor

@wmiipac wmiipac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a ku8 build, from my local build with the branch I don't see problems. The ISSA image looks odd though sometime, may be has to do with the image resolution. It will be good to test with a ku8 build so we can compare notes.

@ejoliet
Copy link
Contributor Author

ejoliet commented Jun 5, 2019

Thanks!
I'll have a look again soon. If you didn't see any problem i will merge after ai recheck the ISSA issue you saw.

@ejoliet ejoliet merged commit 5c7c5a2 into dev Jun 7, 2019
@ejoliet ejoliet deleted the IRSA-2442-add-issa-images branch June 7, 2019 18:29
@robyww robyww added enhancement Image FITS images labels Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants