FIREFLY-106:Add more instrument footprint #816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejoliet
requested changes
Jun 1, 2019
| const SOFIA_INST = new Enum(['FORCAST', 'FIFI-LS']); | ||
| //To add a new Sofia instrument, add it in SOFIA_INST. If the new instrument has submenu, create a menu list like | ||
| // SOFIA_INST_FORCAST_TEXT and then add it to SOFIA_INSTRUMENTS | ||
| const SOFIA_INST = new Enum(['FORCAST', 'FIFI-LS', 'FLITECAM', 'FPI+', 'HAEWC+']); |
There was a problem hiding this comment.
I've noticed that HAWC+ was misspelled here.
There was a problem hiding this comment.
@ejoliet Good catch. I was waiting for the dev ready to push my changes. I just pushed my changes. Thanks!
Add more instructment footprints
lznakano
force-pushed
the
FIREFLY-106-sofiaFootPrint
branch
from
36925b3 to
0b48132
Compare
ejoliet
approved these changes
Jun 7, 2019
|
@vandesai1 the PR has been merged already, look at irsadev. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Footprints are added for three Sofia instruments.
Please test it using URL: https://irsawebdev9.ipac.caltech.edu/firefly-106-sofiaFootprint/irsaviewer/