IRSA-793 IRSA-798-add image type option to main panel add image source panel option #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add source and type options Changed the RadioGroupInputField and RadioGroupInputFieldView to allow a customized label style
loitly
approved these changes
Nov 14, 2017
| @@ -13,7 +13,7 @@ import FieldGroupUtils, {getFieldVal} from '../fieldGroup/FieldGroupUtils.js'; | |||
| import {dispatchComponentStateChange} from '../core/ComponentCntlr.js'; | |||
| import {updateSet} from '../util/WebUtil.js'; | |||
|
|
|||
| import './ImageSelect.css'; | |||
| import './NewImageSearchPanel.css'; | |||
There was a problem hiding this comment.
Not duplicating the style is a good idea, but in this case, most of the style in ImageSelect.css is for ImageSelect only. You should have just moved the relevant style from ImageSelect to NewImageSearchPanel.css.
|
Thanks @Loi for reviewing it. OK, I will do what you suggested in the dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add source and type options
Changed the RadioGroupInputField and RadioGroupInputFieldView to allow a customized label style
Combine two .css file to one as NewImageSearch.css
Note:
For three color images, only irsa works. You have to check both missionId and band. More work is needed to get three color images work.