Skip to content

DM-9787: Ensure that Firefly package's JSDoc content is updated on firefly.lsst.io #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2017

Conversation

loitly
Copy link
Contributor

@loitly loitly commented Nov 8, 2017

  • add JsDoc generation to Firefly standalone build procedure and publish it to firefly.lsst.io
  • fix broken links
  • move .md files in ./tutorial back into ./docs
  • stage jsdocs related files before build, so it can be modified without touching source.
    this is needed to convert md style links to docstrap url and tutorial creation.

To Test:

git checkout DM-10982_generate_jsdoc
gradle clean :firefly:buildJsDoc
open build/firefly/war/docs/js/index.html

…refly.lsst.io

- add JsDoc generation to Firefly standalone build procedure and publish it to firefly.lsst.io
- move .md files in ./tutorial back into ./docs
- stage jsdocs related files before build, so it can be modified without touching source.
  this is needed to convert md style links to docstrap url and tutorial creation.
@loitly loitly requested a review from xiuqin November 8, 2017 01:23
Copy link
Contributor

@xiuqin xiuqin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a change to remove the extra word "see". Looks good!

@loitly loitly merged commit 5656cbc into dev Nov 9, 2017
@loitly loitly deleted the DM-10982_generate_jsdoc branch November 9, 2017 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants