Skip to content

IRSA-810: Replace left hand options links to top left hand tabs (FinderChart) #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2017

Conversation

loitly
Copy link
Contributor

@loitly loitly commented Oct 25, 2017

https://caltech-ipac.atlassian.net/browse/IRSA-810

Also:

  • added flow:horizontal option to SearchPanel to display search items horizontally on top
  • clean up FinderChart's form layout

More changes are in ife under the same branch
To Test:

You should see that the left navigation panel is now replaced by a top tab-style navigation.
I've also removed borders, margin and padding to have a cleaner look.
Let me know what you think.

…erChart)

- added flow:horizontal option to SearchPanel to display search items horizontally on top
- clean up FinderChart's form layout
@loitly loitly requested review from ejoliet and lznakano October 25, 2017 23:12
Copy link
Contributor

@lznakano lznakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. It worked great.

@loitly loitly merged commit ea94f21 into dev Oct 31, 2017
@robyww robyww deleted the IRSA-810_SearchPanel_horizontal_view branch November 21, 2017 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants