Skip to content

DM-11856: framework for client properties defined at build time #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2017

Conversation

loitly
Copy link
Contributor

@loitly loitly commented Oct 24, 2017

https://jira.lsstcorp.org/browse/DM-11856

  • define '__$' as a prefix to indicate client property
  • added getProp() to WebUtil.js to access the property on the client
    See help.base.url in config/app.config as an example.

Everything should work as before. More changes under the sam branch in ife and suit as well.

@loitly loitly requested review from robyww and tgoldina October 24, 2017 22:47
Copy link
Contributor

@tgoldina tgoldina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good now.

May be we should look into circular-dependency-plugin for webpack. The circular dependency bugs are hard to notice, especially when the modules are loaded in different order in a test...

Copy link
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good.

@loitly loitly merged commit 55da72b into dev Oct 26, 2017
@loitly loitly deleted the DM-11856_client_global_var branch October 26, 2017 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants