Skip to content

IRSA-870: added PDF, HTML, PNG and FITS files download for seip and akari #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2017

Conversation

ejoliet
Copy link
Contributor

@ejoliet ejoliet commented Oct 19, 2017

I've added the files download for SEIP (and AKARI when IRSA-820 is done on client side) on server for Finderchart. There is same branch name in IFE.

Build from there Finderchart, and test searching for SEIP/WISE, try to download pdf, html png and fits.

I've also fixed a rounding problem for small size (<1MB) displayed in background monitor status.

Let me know.

@ejoliet ejoliet requested a review from loitly October 19, 2017 23:38
@ejoliet ejoliet changed the title IRSA-870: added seip and akari IRSA-870: added PDF, HTML, PNG and FITS files download for seip and akari Oct 20, 2017
@ejoliet ejoliet requested a review from lznakano October 20, 2017 00:04
@ejoliet
Copy link
Contributor Author

ejoliet commented Oct 20, 2017

Should be good also to test PDF export from Finderchart API.

Copy link
Contributor

@loitly loitly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I did a couple of tests, and it was woking fine.

* @param wp
* @param survey for atlas, survey is in form of 'schema.table'
* @param band SEIP exmaple 'irac1'
* @param filter for SEIP, it should loo like type=science and fname like %.mosaic.fits
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find where "type=science and.." is specified. Is this something that's given via meta, or it's something we need to send along as part of IBE's api? My concern is where this logic is kept.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it will be given from the master table but for FC3 we need to set it in the code. And yes, IBE needs it as part of the query (where clause), different datasets have different filter.

Once we have the framework in place for IV new image search working, and decide to bring the same component to FC, we will need to refactor the FC server code so it can handle generic web plot request and download file from reading the same master table.

@ejoliet ejoliet merged commit e64ae06 into dev Oct 21, 2017
@ejoliet ejoliet deleted the IRSA-870-fc-fits-download branch October 21, 2017 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants