IRSA-924: fix issues found in new image search #481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add select/deselect all at the dataproduct(project) level - fix mission filter now that mission info is available - make count returns the number of dataproduct instead of bands(images) - make CollapsiblePanel's header takes a string or a component. - make ImageSelect requires a way to register changeListener - fix firefly-dev.html not showing images - add option to FormPanel to allow unmounted fields in the request - set NewImageSearchPanel to take unmounted fields
lznakano
approved these changes
Oct 17, 2017
ejoliet
requested changes
Oct 18, 2017
There was a problem hiding this comment.
Is awesome component! Filters works! and selecting dataset all bands also!!
I see couple of issues that i'm not sure if it's from the code or from the table we are curating.
- some wavebands doesn't appear in filter
- mission names are upper case but in the filter they are lower case, this shoud be consistent.
- images request fail for newest added datasets (SEIP for example), i will into it but i guess is the web plot request in the json object not correcty set.
I see 'null' values in the URL request:
http://irsa.ipac.caltech.edu/IBE?table=null.null&POS=10.674300,40.865290&mcen&where=band_name+IN+%28%27IRAC1%27%29+AND+%22%27file_type%27%3Dscience+and+fname+like+%27%25.mosaic.fits%27%22
We should discuss that before merging.
|
Not priority/urgent, but I will also raise separate ticket to add a help anchor for tooltip and link to mission/dataset info |
ejoliet
approved these changes
Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://caltech-ipac.atlassian.net/browse/IRSA-924
To test:
http://localhost:8080/firefly/firefly-dev.html