DM-12208: Check if the document is loaded before rendering firefly #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loitly
approved these changes
Oct 12, 2017
| if (viewer) { | ||
| ReactDOM.render(React.createElement(viewer, props), | ||
| document.getElementById(props.div)); | ||
| if (window.document.readyState==='complete' || window.document.readyState==='interactive') { |
There was a problem hiding this comment.
Wouldn't it be more straight forward if you were checking for 'loading' instead?
if (loading)
- add load listening
There was a problem hiding this comment.
Your right, that would look cleaner. Maybe it is because I am just not that familiar with readyState but I did it this way because it calls out that states I care about, therefore a little more self documenting. I think I will leave it this way for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to test:
Load firefly. It should work.